add TypeScript defintions#16
Merged
Merged
Conversation
Collaborator
|
If I see this correctly you only allow two values for source. That's wrong. |
Contributor
Author
|
@stoecker I see, would you suggest a generic defintion like this: source: `${'wikidata' | 'osm'}:P${number}`or explicitly listing every value which is currently hardcoded in this repository: source: `wikidata:P${1630 | 3303}` | `osmwiki:P8` |
Collaborator
|
The first looks better to me. |
Contributor
Author
|
cool, updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helpful for anyone importing the npm package from JavaScript or TypeScript.
Even people who don't use type-checking with still benefit, because IDEs will use these defintions to provide auto-complete suggestions. For example: